1.5 KiB
WingGraphExport Bugs
GetLinkedTo() does not follow reroute/knot chains
The helper comment in WingGraphExport.h says a linked knot node should be followed to the far end of the chain, but the implementation in WingGraphExport.cpp only returns LinkedTo[0]. That means exported pin sources can name the reroute node instead of the real upstream source, which makes the dump inaccurate for graphs that use reroute nodes.
String-like pin defaults are emitted without escaping
FormatPinSource() wraps PC_String, PC_Name, and PC_Text defaults in quotes, but it prints Pin->DefaultValue and Pin->DefaultTextValue.ToString() verbatim at WingGraphExport.cpp. Any embedded quotes, backslashes, or newlines will produce ambiguous output and can make the dump impossible to parse back reliably.
Suppressed minor-property notice is never emitted
EmitNode() sets SuppressedDetails = true when it hides secondary properties, and EmitDetailsSuggestion() is clearly meant to warn the caller afterward. But neither constructor calls WingGraphExport::EmitDetailsSuggestion, so the user never sees the hint to rerun with details=true.